Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement topicCopy for #1023 #1025

Merged
merged 2 commits into from
Apr 26, 2024
Merged

implement topicCopy for #1023 #1025

merged 2 commits into from
Apr 26, 2024

Conversation

petersilva
Copy link
Contributor

close #1023

one way to resolve the differences between v2 and sr3 in topic processing.

  • add topicCopy option.
  • set to false for all components (because we want all components, as much as possible, to have the same defaults.)
  • when converting a shovel or a winnow from v2, set topicCopy to true, so it behaves the same.

otherwise some logic to validate input topics and only set subtopic if they really meet sarracenia expectations.

Copy link

github-actions bot commented Apr 24, 2024

Test Results

209 tests  ±0   201 ✅ ±0   16s ⏱️ -1s
  1 suites ±0     8 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit b0b5a9e. ± Comparison against base commit 6839407.

♻️ This comment has been updated with latest results.

Copy link

Coverage

Coverage Report •
FileStmtsMissCoverMissing
__init__.py4033990%69–70, 72, 79, 82, 86–87, 89–90, 97, 103, 106, 108–109, 111–112, 114–115, 319, 430, 463, 530–531, 560–561, 607, 620, 622, 632–634, 644–645, 674, 683, 779, 812, 828, 879
config.py1414106924%38, 40–43, 68, 74, 326–328, 332, 336, 344, 346–348, 360–361, 363–364, 366, 368, 375, 377–378, 380, 382–383, 385, 391, 393–394, 396, 398–399, 401, 404, 406–412, 414–420, 422, 424, 433–439, 441–445, 447, 449, 451–453, 455, 457–459, 461–463, 465, 467–468, 470–472, 474, 476–477, 479–482, 484–485, 487, 496, 498, 502–507, 509, 514–515, 517, 521–528, 531–532, 536, 538, 540–541, 545, 547, 549–550, 554–555, 557–559, 562–565, 567, 769–770, 838–845, 847, 849–850, 867, 873–884, 888, 892–895, 897, 901, 906–908, 914, 921, 923, 939, 944, 947, 954–955, 958, 963–967, 970–972, 978–982, 984–985, 987–990, 992–993, 995–996, 1004, 1006–1012, 1020, 1023–1026, 1028–1030, 1032, 1034–1035, 1037, 1039–1042, 1080–1081, 1087, 1089–1091, 1093–1095, 1097–1099, 1108, 1110–1112, 1121–1123, 1130, 1132–1133, 1141, 1146–1154, 1156, 1158–1159, 1161–1163, 1165–1166, 1172, 1174–1175, 1177–1178, 1180–1181, 1183, 1189–1190, 1194–1195, 1197–1202, 1204, 1209–1210, 1212–1213, 1223–1225, 1227–1228, 1232, 1250–1251, 1258, 1262–1263, 1265, 1267–1268, 1270, 1272, 1280–1281, 1283–1286, 1288–1289, 1291, 1293–1294, 1301–1302, 1304, 1306–1307, 1309, 1313–1322, 1343–1346, 1348, 1353–1356, 1358, 1360, 1362, 1365–1370, 1372, 1375–1376, 1378, 1381, 1383, 1385–1386, 1388–1390, 1393–1395, 1397, 1399, 1401, 1407–1408, 1410, 1412, 1414, 1416–1417, 1419–1423, 1425–1428, 1430–1432, 1434–1440, 1444–1445, 1447–1452, 1454–1456, 1458–1459, 1461–1467, 1469, 1471–1473, 1475–1476, 1480, 1482–1483, 1485, 1489–1491, 1493, 1495–1497, 1499–1504, 1507–1509, 1512–1532, 1534–1535, 1537–1538, 1540–1557, 1560–1567, 1569–1570, 1572–1573, 1582–1584, 1586–1587, 1589–1593, 1596–1605, 1607–1614, 1616–1628, 1630–1633, 1635–1637, 1639–1642, 1645–1651, 1654–1660, 1663–1666, 1670, 1674–1675, 1677–1678, 1680, 1682–1683, 1685, 1688, 1703, 1705, 1707–1713, 1715, 1717–1725, 1727, 1735–1738, 1741–1748, 1750–1751, 1754–1755, 1757–1763, 1765–1766, 1768, 1782, 1784–1785, 1787–1788, 1790–1791, 1793–1796, 1798, 1801, 1806–1807, 1810–1812, 1814–1818, 1820–1822, 1824–1826, 1828–1830, 1832–1834, 1836–1837, 1839, 1843–1845, 1847–1852, 1855–1856, 1858, 1860–1863, 1865–1866, 1868–1869, 1871–1873, 1875–1876, 1879–1880, 1882, 1884–1885, 1887–1894, 1896, 1898–1901, 1903–1905, 1907–1911, 1913–1915, 1917–1919, 1921–1923, 1925–1929, 1932–1933, 1935–1938, 1940–1942, 1946–1947, 1949–1950, 1952–1955, 1959–1973, 1976–1979, 1981–1982, 1984–1987, 1990–1992, 1996, 1998–2021, 2024–2027, 2029, 2044–2047, 2049–2051, 2053, 2055, 2063–2064, 2066, 2068–2071, 2073–2076, 2078, 2084–2085, 2087, 2092–2093, 2095–2105, 2107–2118, 2122–2126, 2128, 2151, 2154–2155, 2158–2159, 2166–2167, 2173, 2175, 2195–2196, 2199–2200, 2203–2204, 2207–2208, 2211–2212, 2226–2228, 2230–2234, 2243, 2252–2253, 2256–2258, 2263–2264, 2267–2269, 2274–2275, 2278–2280, 2285–2286, 2288–2291, 2309–2310, 2342–2343, 2345, 2347–2348, 2351–2352, 2355–2356, 2359–2361, 2363, 2365, 2396, 2400–2401, 2403, 2408, 2414, 2416, 2421, 2426, 2430, 2437, 2447, 2450, 2454, 2458, 2462, 2466, 2471, 2475, 2479, 2484, 2489, 2494, 2498, 2503, 2507–2508, 2511, 2517, 2521, 2525, 2528, 2531, 2535, 2538, 2543, 2549, 2554, 2559, 2566, 2573, 2577, 2586–2587, 2592, 2597, 2602, 2606, 2608–2609, 2611–2612, 2614–2616, 2618, 2628, 2633, 2644–2653, 2671, 2673, 2680, 2682, 2684, 2686–2687, 2689–2690, 2692, 2694–2695, 2697–2698, 2700, 2702, 2707–2709, 2711, 2713, 2715–2719, 2721–2723, 2728, 2733–2735, 2737–2738, 2742–2744, 2746, 2748, 2750–2760, 2762, 2764, 2766–2776, 2778–2784, 2786, 2791, 2793, 2795–2796, 2799–2801, 2804–2807, 2812
sr.py201820180%8, 21, 23–42, 44, 46–49, 51–52, 54, 56, 58, 66, 68, 72–73, 75, 80–84, 86–88, 91, 103, 107, 111–119, 121, 123, 128–129, 131, 133–134, 136, 138, 140, 142–151, 153, 157, 159, 162–165, 167, 169–171, 176, 181, 184–186, 188–190, 192–193, 198–199, 202, 206–210, 212–213, 215–216, 221, 224–225, 228–234, 236–237, 239, 241, 244, 247, 249–257, 259, 262, 266–277, 279, 281–290, 293–294, 296, 298–300, 302, 304, 306–320, 322–323, 325–329, 335–338, 340–341, 345–347, 349–350, 352, 354–357, 359, 361, 363, 369, 371–372, 374–375, 377–378, 380, 383–384, 386–387, 389–392, 394, 397–408, 410, 414–419, 421–442, 444–447, 450, 453–456, 458–461, 463–465, 467, 469–476, 478–479, 482–485, 487, 489–490, 492–493, 495–497, 499–512, 515, 518, 520–522, 524, 526–527, 529–531, 533–535, 537–538, 540–541, 543–546, 548–551, 554–557, 559, 561–562, 564, 567–577, 579, 581–583, 585–586, 588, 590–594, 596, 598–603, 605–606, 608–614, 616, 618–621, 624, 628–641, 643, 645–650, 652, 654–655, 657–659, 662, 664–669, 675–682, 684, 686–697, 699–701, 703–705, 707, 709, 711–715, 717, 719, 724, 728–730, 732–733, 735, 737–738, 740–745, 747–748, 750, 755, 759–761, 763–764, 766, 768–769, 771–776, 778–779, 781, 786–787, 789–791, 793–795, 797, 799, 808, 810–811, 813–820, 824, 826, 829–831, 833, 835–836, 838–841, 843–846, 848, 850–852, 854, 856–857, 859, 861–862, 864, 867–868, 870–875, 877–878, 880–884, 886, 893–894, 896–897, 900–905, 907–910, 912–922, 924, 928–930, 932, 936, 938, 940–941, 943–956, 958, 962–963, 965–966, 968, 970–978, 980, 982–994, 997, 999–1000, 1002–1007, 1009–1013, 1015–1017, 1019–1025, 1027–1028, 1032, 1039–1044, 1046–1048, 1050–1056, 1058–1065, 1067–1069, 1071–1074, 1076–1081, 1083–1085, 1087–1089, 1092–1094, 1096–1098, 1100–1101, 1103–1105, 1107–1114, 1119–1123, 1129–1132, 1134–1135, 1138–1140, 1142–1145, 1147, 1150, 1155–1157, 1159–1166, 1168–1169, 1171–1172, 1179–1181, 1183–1185, 1187, 1191, 1195, 1199–1202, 1204, 1207, 1209, 1211, 1213–1214, 1217–1219, 1221–1231, 1233–1235, 1238–1239, 1241–1250, 1253–1255, 1257–1262, 1264–1266, 1268–1270, 1272–1273, 1277–1283, 1285, 1287–1290, 1292–1296, 1300–1301, 1303–1304, 1306, 1309, 1311–1316, 1318–1326, 1328, 1330–1336, 1339–1353, 1357, 1363–1366, 1373–1374, 1377–1381, 1383–1387, 1390, 1397–1398, 1401–1404, 1406, 1408–1419, 1422–1425, 1427, 1429–1430, 1432–1440, 1442–1445, 1447–1451, 1453–1454, 1456–1458, 1460–1468, 1471, 1473–1477, 1479–1480, 1482–1483, 1485–1487, 1489–1490, 1493, 1495, 1497–1498, 1500–1501, 1503, 1505–1506, 1508, 1510–1513, 1515–1519, 1521–1526, 1528–1529, 1531, 1534–1537, 1539, 1541–1542, 1544–1552, 1554–1562, 1564–1565, 1567–1568, 1570, 1572–1573, 1575–1576, 1579, 1581–1585, 1587–1588, 1590–1591, 1593–1597, 1599–1601, 1603, 1605, 1609, 1611–1613, 1617–1622, 1624–1626, 1628, 1630, 1632, 1634, 1636, 1638–1640, 1642, 1644–1649, 1651, 1653, 1655, 1666–1669, 1671–1683, 1685–1688, 1697–1700, 1703–1706, 1708, 1710–1711, 1713–1721, 1724–1726, 1728–1729, 1731, 1733–1738, 1740–1741, 1743–1745, 1747–1749, 1751, 1753–1760, 1762, 1764, 1768–1769, 1772–1777, 1779, 1781–1785, 1787, 1789–1791, 1793, 1799–1800, 1803–1805, 1807–1817, 1819, 1821–1823, 1825, 1830–1832, 1834–1835, 1839–1841, 1845–1847, 1852, 1856–1858, 1862, 1864, 1866, 1870–1872, 1874–1875, 1877–1886, 1888–1889, 1891, 1893–1895, 1897–1899, 1902, 1904–1906, 1908–1909, 1911–1912, 1914–1915, 1917, 1919–1925, 1927–1928, 1930–1931, 1933–1935, 1937, 1943–1950, 1952–1954, 1956–1957, 1959, 1961, 1966–1969, 1973, 1978–1995, 1997–2002, 2005–2013, 2015–2018, 2020–2023, 2026–2027, 2029–2032, 2035–2038, 2040, 2042–2043, 2045–2053, 2055, 2061–2062, 2064–2068, 2070, 2073, 2075–2077, 2079–2084, 2086, 2088, 2094–2105, 2107, 2112, 2114–2116, 2118–2120, 2123, 2125–2131, 2133–2134, 2136, 2139–2141, 2143–2144, 2147–2150, 2152–2155, 2157–2160, 2162–2164, 2166–2168, 2170, 2173–2176, 2179, 2181–2185, 2187–2190, 2192–2195, 2197–2203, 2205, 2207–2211, 2213–2215, 2217–2227, 2229–2231, 2234–2235, 2237–2244, 2246–2248, 2250–2255, 2258–2263, 2265–2266, 2268–2270, 2272, 2276–2277, 2285–2286, 2288–2301, 2303–2315, 2317–2336, 2338–2344, 2346–2348, 2350–2351, 2353–2375, 2377, 2382, 2384–2386, 2388–2389, 2391, 2393–2394, 2396–2397, 2399, 2402–2403, 2405–2407, 2409–2410, 2412–2427, 2429–2435, 2437–2438, 2441–2446, 2448–2450, 2452–2458, 2460–2461, 2463–2469, 2471, 2473–2474, 2476–2478, 2480–2484, 2486–2490, 2492–2494, 2496–2497, 2499–2502, 2504–2507, 2509–2510, 2514–2515, 2517, 2519–2520, 2522, 2524, 2526–2531, 2533–2534, 2536, 2538, 2547–2548, 2562–2564, 2567–2568, 2571–2572, 2575, 2579–2581, 2583–2589, 2592, 2594, 2598, 2601–2602, 2604, 2606, 2613, 2620–2623, 2625–2632, 2634–2641, 2643–2644, 2646–2647, 2649–2651, 2653–2658, 2660–2661, 2663–2674, 2676–2679, 2681–2686, 2688–2699, 2701–2702, 2704–2705, 2707–2715, 2717–2726, 2728–2729, 2731–2733, 2735, 2737–2739, 2741–2742, 2744–2745, 2747–2750, 2752–2757, 2759–2762, 2764, 2767, 2772, 2775, 2778, 2781–2784, 2786, 2788, 2790–2791, 2793–2795, 2797, 2799–2801, 2803–2805, 2807–2808, 2810–2811, 2814, 2817, 2819–2820, 2823–2824, 2827, 2829, 2832, 2834–2837, 2840, 2842–2847, 2850, 2854–2857, 2859, 2861, 2874–2875, 2877–2880, 2882–2883, 2885, 2887, 2896–2897, 2899, 2909, 2913, 2918–2919, 2922, 2924–2926, 2928, 2930, 2935, 2945, 2950–2952, 2954, 2956–2957, 2960, 2966–2968, 2970–2972, 2974–2976, 2978–2981, 2983–2986, 2988–2989, 2991–2992, 2994–2995, 2997–2998, 3000–3001, 3003–3004, 3006–3007, 3009–3010, 3012–3013, 3015–3016, 3018–3022, 3024–3026, 3028–3029, 3031–3033, 3035–3037, 3039–3041, 3043–3045, 3047–3049, 3051
flow
   __init__.py156614904%36, 122–123, 125, 127–129, 131–133, 140, 142–143, 148, 150–151, 156, 158–159, 161, 164–166, 169–174, 178, 181, 187–189, 191, 194, 197, 200–202, 205–206, 209, 211, 214–215, 219, 224–226, 228–229, 231, 235–236, 238–244, 246–253, 256–259, 261–262, 264, 266, 268, 270–272, 276–279, 281–285, 288–290, 292–296, 304–307, 309, 311–316, 318–321, 323–328, 334–337, 339–341, 348, 351–352, 354–364, 366, 368, 374–375, 378, 381–383, 388–391, 396–399, 401–405, 409–415, 417–421, 430–431, 433, 435, 437–443, 445–447, 449–450, 454–456, 458, 460–464, 466–467, 469, 471–474, 476, 478, 480–481, 483–484, 486–488, 490–491, 493, 496–498, 501–502, 504–506, 508–509, 511–512, 514, 516–517, 519, 521, 523, 525–526, 528, 531–532, 534, 536, 538, 540, 542, 546–547, 549–553, 557–559, 561, 564–565, 567–572, 574, 576–578, 580, 595, 597–600, 602–604, 606, 608–614, 616–624, 626, 628, 630–631, 633–638, 640, 642, 644–645, 647–664, 667–668, 671, 673–674, 705, 707–709, 711, 713, 716, 723–724, 730–732, 734–741, 747–749, 755, 757–760, 762, 768–770, 773–781, 784, 788, 790–791, 793–796, 801–803, 805–808, 810, 812–817, 819–821, 823–831, 833–842, 844–845, 847, 850, 852–853, 855–857, 862, 865, 867–872, 874–879, 883, 885–886, 888–889, 891–903, 905–908, 910, 912, 914–915, 917, 919, 921–928, 930–933, 935–938, 941, 944, 946, 950–951, 953–960, 965, 967–968, 970, 975, 977, 979, 981, 983, 985, 989–993, 997–1001, 1004–1007, 1009–1013, 1015–1017, 1020–1022, 1024, 1027–1028, 1030–1033, 1035, 1037–1041, 1047–1048, 1051–1052, 1054, 1058, 1061–1063, 1066–1067, 1069–1075, 1078–1081, 1083, 1085–1086, 1088, 1090–1096, 1098–1101, 1104–1105, 1107, 1109, 1111, 1113–1115, 1121, 1125–1128, 1130–1135, 1137–1139, 1141–1149, 1151–1154, 1157–1161, 1163–1165, 1173–1178, 1180, 1182–1183, 1186–1190, 1192–1193, 1195, 1197–1200, 1202, 1204–1207, 1209–1211, 1213, 1215, 1220–1222, 1226, 1229, 1239, 1245, 1250, 1252, 1254–1258, 1260–1262, 1264, 1268–1271, 1273–1275, 1278, 1283–1290, 1292, 1295–1296, 1298–1299, 1303, 1321–1322, 1327–1328, 1334–1335, 1337, 1339, 1343–1345, 1347–1354, 1356–1357, 1359, 1361, 1366–1367, 1369, 1371–1372, 1374, 1376, 1378–1379, 1381–1384, 1387, 1389, 1392–1394, 1396, 1403, 1405–1414, 1416, 1422–1425, 1432, 1434, 1436–1442, 1445–1447, 1454–1456, 1458–1463, 1465–1467, 1469–1470, 1472, 1474–1475, 1477–1483, 1492, 1501–1507, 1509–1511, 1513–1514, 1517–1519, 1521–1522, 1524–1526, 1528, 1530, 1541–1544, 1546, 1548, 1552–1553, 1555–1556, 1558–1565, 1567–1568, 1570–1571, 1573–1578, 1582, 1586–1591, 1593–1596, 1598–1602, 1607–1608, 1610–1613, 1615–1619, 1624–1625, 1629–1632, 1634–1638, 1641–1642, 1644–1647, 1649–1653, 1656–1657, 1660, 1662–1675, 1678, 1681, 1684, 1686–1687, 1689–1690, 1694, 1696–1697, 1700–1702, 1705, 1708–1709, 1713–1715, 1717, 1719–1720, 1723–1729, 1733–1734, 1736–1737, 1739–1740, 1742–1745, 1747–1751, 1753, 1755, 1757–1758, 1760, 1764, 1774, 1776–1781, 1783, 1785, 1789, 1791–1796, 1798, 1800, 1802–1803, 1805, 1807–1808, 1810, 1813–1814, 1816–1817, 1819–1821, 1823–1831, 1833–1841, 1843, 1845–1847, 1849–1855, 1857–1858, 1860–1861, 1863–1866, 1868, 1870–1879, 1881–1882, 1884–1887, 1889, 1891–1895, 1897–1901, 1903–1905, 1915, 1917–1919, 1921–1924, 1926, 1928–1936, 1938–1939, 1941–1942, 1944, 1948, 1956–1959, 1961, 1963–1964, 1966–1967, 1970, 1974–1979, 1981, 1983, 1987, 1991–1993, 1997–1998, 2002, 2004–2005, 2007–2015, 2017–2019, 2023, 2027–2028, 2032–2033, 2035–2038, 2040, 2043–2046, 2049–2050, 2052–2053, 2055–2057, 2059–2060, 2062–2063, 2070–2071, 2073–2077, 2079–2080, 2082, 2084–2085, 2087–2088, 2090–2092, 2095–2102, 2104–2106, 2108–2111, 2115–2117, 2120–2126, 2128–2129, 2131–2132, 2135, 2138, 2140, 2142–2146, 2148–2151, 2153–2158, 2160, 2162–2163, 2165, 2167–2171, 2173, 2175–2179, 2181–2186, 2192, 2195, 2197, 2203–2204, 2206–2207, 2213, 2215–2216, 2222–2225, 2227–2228, 2230–2231, 2237–2243, 2245–2251, 2253–2263, 2265–2277, 2284–2306, 2313–2314, 2317–2318, 2320–2322, 2324, 2326–2329, 2331–2332, 2335–2337, 2341, 2345, 2349, 2351–2353, 2355–2356, 2358–2359, 2361–2365, 2368, 2370, 2372, 2374–2378, 2381–2386, 2388–2394, 2397, 2399, 2401–2406, 2409, 2411, 2413, 2415–2418, 2422–2423, 2426, 2430, 2432, 2435, 2437–2441, 2444–2448, 2450–2455, 2457, 2459, 2461, 2468, 2473–2475, 2477, 2479–2482, 2484–2485, 2487, 2489, 2491–2498, 2500–2501, 2503–2508, 2514–2525, 2527–2531, 2533–2542, 2551–2554, 2556, 2559–2562, 2564–2566, 2568–2570, 2572–2574, 2576–2578, 2586–2589, 2591–2594, 2596–2599
   shovel.py9366%19–20, 22
   winnow.py9366%20–21, 23
moth
   amqp.py4534530%25–27, 29, 31, 33–37, 39–40, 42–43, 49, 51, 72, 87–89, 91–96, 99–101, 104–106, 108–110, 112–113, 117–121, 123–125, 127–128, 130, 132–136, 138, 140–147, 149–151, 153–155, 157, 160–161, 163–165, 167–168, 171–172, 174, 176–178, 180–187, 189, 191, 194, 196, 202, 204, 206, 210–211, 213–214, 216, 218–220, 222–223, 225, 227, 235–239, 241, 243, 245–246, 249, 252–253, 255, 262, 264, 266–268, 270–272, 274, 276, 278–280, 282, 284, 286, 288, 290, 292–296, 299, 302, 304–310, 313–314, 316, 318, 326–327, 329–331, 333–334, 337, 339, 341–343, 346, 354–358, 360, 362–363, 365–367, 371, 373–375, 378–380, 384–385, 388, 392, 394, 396–401, 404, 406–407, 411–413, 415–416, 419, 421, 423, 425, 427–428, 430–433, 435, 437–441, 443, 447–449, 451–453, 455–457, 460–461, 466–467, 469–473, 476, 481, 485–487, 489–490, 494, 496, 498, 500–502, 504–507, 510, 512–516, 518–525, 527, 529, 531–533, 535–539, 541, 543, 545–547, 549–559, 561, 563, 565–567, 569–571, 573–575, 577–586, 588–592, 594–597, 599, 601–602, 604–607, 609, 613–615, 619, 621, 624–630, 632, 634–636, 639–640, 642, 644, 646, 648, 656–658, 661–668, 671, 673, 676, 681–684, 686–689, 692, 695, 697, 700, 702, 704, 706–707, 710, 712–713, 715, 717, 719–721, 723–728, 730–731, 733, 735–738, 740–742, 744–745, 747, 752–755, 758–760, 762–765, 767–771, 773–774, 776–777, 779–781, 783, 790–791, 793–797, 799–801, 803–804
TOTAL153431250818% 

Test Results

Tests Skipped Failures Errors Time
209 8 💤 0 ❌ 0 🔥 16.106s ⏱️

@petersilva petersilva merged commit 91e330c into development Apr 26, 2024
4 checks passed
@petersilva petersilva deleted the issue1023 branch May 7, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What is correct "topic" processing in sr3?
2 participants